Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix authorization header casing in storageUtils #2902

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Fix authorization header casing in storageUtils #2902

merged 1 commit into from
Jun 11, 2024

Conversation

Gkrumbach07
Copy link
Member

closes: https://issues.redhat.com/browse/RHOAIENG-8473

Description

changes header key to capital A

How Has This Been Tested?

get image and test on cluster

Test Impact

n/a backend

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from christianvogt and ppadti June 11, 2024 16:55
andrewballantyne
andrewballantyne approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

Test on a cluster before merging. But lgtm.

@openshift-ci openshift-ci bot added the do-not-merge/hold This PR is hold for some reason label Jun 11, 2024
@Gkrumbach07
Copy link
Member Author

/retest

@codecov Codecov
Copy link

codecov bot commented Jun 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.63%. Comparing base (ed9f7e4) to head (d6bd7d7).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2902      +/-   ##
==========================================
- Coverage   78.64%   78.63%   -0.02%     
==========================================
  Files        1120     1120              
  Lines       23758    23772      +14     
  Branches     5979     5984       +5     
==========================================
+ Hits        18685    18693       +8     
- Misses       5073     5079       +6

see 8 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed9f7e4...d6bd7d7. Read the comment docs.

andrewballantyne
andrewballantyne requested changes Jun 11, 2024
View reviewed changes
Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For posterity -- this didn't work when we tested it on cluster. I asked Gage to change up the way we are calling for resources and use the passThroughResource utility instead of the K8s library. It is possible the K8s lib is overriding the Auth token no matter what.

@Gkrumbach07 Gkrumbach07 force-pushed the bug/RHOAIENG-8473-incorrect-token-setting-for-s3-download-api branch from 132d771 to d6bd7d7 Compare June 11, 2024 19:40
andrewballantyne
andrewballantyne approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bingo, on cluster success!

@openshift-ci openshift-ci bot added the lgtm label Jun 11, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Gkrumbach07
Copy link
Member Author

/unhold

tested on cluster

@openshift-ci openshift-ci bot removed the do-not-merge/hold This PR is hold for some reason label Jun 11, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 74513a0 into opendatahub-io:main Jun 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewballantyne andrewballantyne andrewballantyne approved these changes

@christianvogt christianvogt Awaiting requested review from christianvogt

@ppadti ppadti Awaiting requested review from ppadti

Assignees

@andrewballantyne andrewballantyne

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gkrumbach07 @andrewballantyne